Too many redirects error in MVC application

Question

I am getting Too many redirects error in my MVC application. After i add UserFilter : ActionFilterAttribute how can i solve this problem ? public class UserFilter : ActionFilterAttribute { public override void OnActionExecuting(ActionExecutingContext context) { int ? userid = context.HttpContext.Session.GetInt32( "id" ); if (!userid.HasValue) { context.Result = new RedirectToRouteResult( new RouteValueDictionary { { "action" , "Index" }, { "controller" , "Admin" } } ); } } }

Sachin Singh · Answer

test this public class UserFilter : ActionFilterAttribute { public override void OnActionExecuting(ActionExecutingContext context) { if (!string.IsNullOrEmpty(context.Request.RawUrl) && context.Request.RawUrl != "/Admin/Index" ) { int ? userid = context.HttpContext.Session.GetInt32( "id" ); if (!userid.HasValue) { context.Result = new RedirectToRouteResult( new RouteValueDictionary { { "action" , "Index" }, { "controller" , "Admin" } } ); } } } }

Sachin Singh · Answer

No, your are doing something wrong i guess, which is creating a loop, for example for me below code is working fine. public class SessionExpireActionFilterAttribute : ActionFilterAttribute { public override void OnActionExecuting(ActionExecutingContext filterContext) { var context = filterContext.HttpContext; if (context.Session != null) { int ? userid = context.HttpContext.Session.GetInt32( "id" ); if( !userid.HasValue ){ string redirectTo = "~/Admin/Index" ; if (!string.IsNullOrEmpty(context.Request.RawUrl)) { redirectTo = string.Format( "~/Account/Logon?ReturnUrl={0}" , HttpUtility.UrlEncode(context.Request.RawUrl)); } result = new RedirectResult(redirectTo); } } filterContext.Result = result; } } } base.OnActionExecuting(filterContext); } }

Sachin Singh · Answer

if nothing is working then use this protected override void OnActionExecuting(ActionExecutingContext Context) { if (!Context.HttpContext.ValidateUrl()) { int ? userid = context.HttpContext.Session.GetInt32( "id" ); if (!userid.HasValue) { context.Result = new RedirectToRouteResult( new RouteValueDictionary { { "action" , "Index" }, { "controller" , "Admin" } } ); return ; } }

Sachin Singh · Answer

the use url .HttpContext.Request.Url if (!string.IsNullOrEmpty(context.HttpContext.Request.Url) && context.HttpContext.Request.Url != "/Admin/Index" )

Sachin Singh · Answer

yes, context is HttpContext public class UserFilter : ActionFilterAttribute { public override void OnActionExecuting(ActionExecutingContext context) { if (!string.IsNullOrEmpty(context. HttpContext .Request.RawUrl) && context. HttpContext .Request.RawUrl != "/Admin/Index" ) { int ? userid = context.HttpContext.Session.GetInt32( "id" ); if (!userid.HasValue) { context.Result = new RedirectToRouteResult( new RouteValueDictionary { { "action" , "Index" }, { "controller" , "Admin" } } ); } } } }

Uygar Kılıç · Answer

Problem solved. Thank you Sachin

Uygar Kılıç · Answer

Dude im still taking the same error so. S hould i add some controller or library in my project ?

Uygar Kılıç · Answer

i changed it and still unfortunaly couldn't fix "Severity Code Description Project File Line Suppression State Error CS1061 'HttpRequest' does not contain a definition for 'Url' and no accessible extension method 'Url' accepting a first argument of type 'HttpRequest' could be found (are you missing a using directive or an assembly reference?)"

Uygar Kılıç · Answer

Man thank you very much for you asnwer but this time i took this error: Severity Code Description Project File Line Suppression State Error CS1061 'HttpRequest' does not contain a definition for 'RawUrl' and no accessible extension method 'RawUrl' accepting a first argument of type 'HttpRequest' could be found (are you missing a using directive or an assembly reference?)

Uygar Kılıç · Answer

Sachin Singh i added your codes but after i added them i have taken this error : Severity Code Description Project File Line Suppression State Error CS1061 'ActionExecutingContext' does not contain a definition for 'Request' and no accessible extension method 'Request' accepting a first argument of type 'ActionExecutingContext' could be found (are you missing a using directive or an assembly reference?)