Index and length must refer to a location within the string.

Question

private bool isvalidyearcode( string ycode) { if (Convert.ToInt32(ycode.Substring(1, 4).ToString()) == 0 | Convert.ToInt32(ycode.Substring(3, 2).ToString()) + 1 != Convert.ToInt32(ycode.Substring(6, 7).ToString()) | Convert.ToInt32(ycode.Substring(5, 1)).ToString() != "-" ) //error { MessageBox.Show( "Invalid Year code" ); return false ; } return true ; }

Bryian Tan · Answer

Look like the index is off, as other member pointed out, the index should start from 0 var ycode = "2012-13" ; Console.WriteLine(Convert.ToInt32(ycode.Substring(0, 4).ToString())); Console.WriteLine(Convert.ToInt32(ycode.Substring(2, 2).ToString()) + 1); Console.WriteLine(Convert.ToInt32(ycode.Substring(5, 2).ToString())); Console.WriteLine(ycode.Substring(4, 1)); Output: 2012 13 13 -

James Axsom · Answer

Hi Sona, I believe what is happening is your basing your substrings as if the starting index is 1. Sub string index start at 0. Let’s examine how your code executes when the parameter ycode comes into the function. ycode =”2012-13” Substring(1,4) would produce 012- as opposed to 2012. In order to get 2012 your substring would need to be Substring(0,4). SubString(3,2) produces 2-. In order to get 12 you would need Substring(2,2) Zero based indexes Value: 2012-13 Indexes: 0123456 Check your other substrings. Hope this helps you.

Guest User · Answer

txt_yearcode.Text=" 2012-13" ;

Nanddeep Nachan · Answer

Can you please provide the input values of ycode for this error?