If statement alternative to optimize code

Question

I can get fare From one city to To another city and selecting One Way , AC using following code private void button1_Click( object sender, EventArgs e) { if (comboBox1.SelectedIndex == 0 && comboBox2.SelectedIndex == 0 && radioButton1.Checked && radioButton3.Checked) { MessageBox .Show( "Your Fare is $225" ); } } The problem is there will many many if satements incase if there are only 5 citis in combo box. What is the best way to choose different approcach to avoid if satemens.

Amit Bisht · Answer

The information you provided is very less, based on few assumption look into below code, I would suggest rather than using multiple if-else split your code for separate operations: Cities is an enum for each city. Call GetFare method and pass from and to city with Ac and two-way journey details. Also, isCaseValid validate that fromCity should always be greater then ToCity public enum Cities { //enum for each city City1 = 0, City2 = 1, City3 = 2, City4 = 3, City5 = 4 } public double GetFare(Cities FromCity, Cities ToCity, bool isAC, bool isTowWayJourney, ref bool isCaseValid ) { double TotalCharge = 0; if (FromCity { int baseFare = CalculateBaseFare(Cities.City1, Cities.City3); if (isAC) //considering ac charges fixed which is 1.5 times of base fare TotalCharge = baseFare * 1.5; if (isTowWayJourney) //tow way journey should be 2 times of 1 way journey TotalCharge = TotalCharge * 2; //validation if FromCity is greater then ToCity isCaseValid = true ; return TotalCharge; } else { //validation if FromCity is greater then ToCity isCaseValid = false ; return TotalCharge; } } public int CalculateBaseFare(Cities fromCity, Cities ToCity) { return FareDefination(fromCity) - FareDefination(ToCity); } public int FareDefination(Cities city) { //considering fare from city1 to city5 and taking difference of charge between journey switch (city) { case Cities.City1: return 0; case Cities.City2: return 150; case Cities.City3: return 350; case Cities.City4: return 400; case Cities.City5: return 750; default : return 0; } }

Ramesh Palanivel · Answer

Hi Talha, The best way is , maintain the root cost details in database ex : chennai - delhi : 5000 chennai - bangalore : 2000 something like that, in future if you want to take change the root cost, it will be best way.. you can change that on db. no need to touch this code level.. and the same way no need to write this in if condition.. just pass the from and to details to db and get the appropriate cost for that..

Sulieman Alkatib · Answer

make a standard value for radio buttons as integer then add it to selected value from combobox