How to return error message

Question

Hi

I have below code . I want if error is encountered in catch statement then some message should be returned

public List<Location> GetAllLocation()
{
List<Location> objLocation = new List<Location>();
try
{
using (SqlConnection con = new SqlConnection(Common.Con))
{
con.Open();
SqlCommand cmd = new SqlCommand("sp_Location", con);
cmd.CommandType = CommandType.StoredProcedure;
cmd.Parameters.AddWithValue("@Action", "R");
SqlDataReader rdr = cmd.ExecuteReader();
while (rdr.Read())
{
objLocation.Add(new Location
{
Id = rdr["Id"].ToString(),
Description = rdr["Description"].ToString(),
GstStateCode = rdr["GstStateCode"].ToString(),
GstStateName = rdr["GstStateName"].ToString(),
GstNo = rdr["GstNo"].ToString(),
IsActive = Convert.ToBoolean(rdr["IsActive"]),
});
}
//return objLocation;
}
}
catch (Exception ex)
{
ExceptionLogging.SendExcepToDB(ex);

}
return objLocation;
}

Thanks

Sachin Singh · Answer

This is what i am saying, although there are multiple ways like using error attribute or global error handler as step 1. web.config "On" > step 2.create a class under App_Start Folder public class FilterConfig { public static void RegisterGlobalFilters(GlobalFilterCollection filters) { filters.Add( new HandleErrorAttribute()); } } step 3. Open Globa.asax and under Application_Start event do this protected void Application_Start() { AreaRegistration.RegisterAllAreas(); RouteConfig.RegisterRoutes(RouteTable.Routes); FilterConfig.RegisterGlobalFilters(GlobalFilters.Filters); // add this } The best approach is this in below link https://www.tutorialsteacher.com/articles/display-custom-error-page-with-error-code-in-aspnet-mvc

Kirtesh Shah · Answer

You can throw the exception from this method. Your controller can handle that error using try/catch, Handler error attributes, global exception filter, and show an error message to View(). catch (Exception ex) { ExceptionLogging.SendExcepToDB(ex); throw new Exception("error message "); } check this article to handle errors from MVC https://www.c-sharpcorner.com/UploadFile/mscratnesh/exception-handling-in-mvc/

Ramco Ramco · Answer

Hi Sachin In the below code what is should write in Catch block. Secondly what should be written in Controller to Handle error. public List GetAllLocation() { List objLocation = new List (); try { using (SqlConnection con = new SqlConnection(Common.Con)) { con.Open(); SqlCommand cmd = new SqlCommand("sp_Location", con); cmd.CommandType = CommandType.StoredProcedure; cmd.Parameters.AddWithValue("@Action", "R"); SqlDataReader rdr = cmd.ExecuteReader(); while (rdr.Read()) { objLocation.Add(new Location { Id = rdr["Id"].ToString(), Description = rdr["Description"].ToString(), GstStateCode = rdr["GstStateCode"].ToString(), GstStateName = rdr["GstStateName"].ToString(), GstNo = rdr["GstNo"].ToString(), IsActive = Convert.ToBoolean(rdr["IsActive"]), }); } //return objLocation; } } catch (Exception ex) { ExceptionLogging.SendExcepToDB(ex); } return objLocation; } *************************** Controller public ActionResult Index() { MyViewModel lvm = new MyViewModel(); lvm.Locations = dbLocation.GetAllLocation().ToList(); lvm.Location = new Location(); return View(lvm); }

Ramco Ramco · Answer

Hi When i write ViewBag in catch statement i get error The name ViewBag does not exist in the current context Secondly if i write return -1 in the catch statement of below logic is it o.k public List GetAllLocation() { List objLocation = new List (); try { using (SqlConnection con = new SqlConnection(Common.Con)) { con.Open(); SqlCommand cmd = new SqlCommand("sp_Location", con); cmd.CommandType = CommandType.StoredProcedure; cmd.Parameters.AddWithValue("@Action", "R"); SqlDataReader rdr = cmd.ExecuteReader(); while (rdr.Read()) { objLocation.Add(new Location { Id = rdr["Id"].ToString(), Description = rdr["Description"].ToString(), GstStateCode = rdr["GstStateCode"].ToString(), GstStateName = rdr["GstStateName"].ToString(), GstNo = rdr["GstNo"].ToString(), IsActive = Convert.ToBoolean(rdr["IsActive"]), }); } //return objLocation; } } catch (Exception ex) { ExceptionLogging.SendExcepToDB(ex); } return objLocation; } Thanks

Sachin Singh · Answer

you can use viewbag or tempdata to display custom messages. catch (Exception ex) { ExceptionLogging.SendExcepToDB(ex); ViewBag.ErrorMessage= ex.Message.ToString(); } // in view @ViewBag.ErrorMessage