How to fill Model with related data w.r.t. model Id

Question

private void GetData(Candidate c)//for candidate index page { c.Alerts = db.Alerts.Where(a => a.CanId == c.CanId).ToList(); c.Bookmarks = db.SavedJobs.Where(sv => sv.CanId == c.CanId).ToList(); c.Applications = db.Applications.Where(app => app.CanId == c.CanId).ToList(); } alerts, bookmarks,applications all are list from different tables i am fetching records from them using CanId is there any way to do this task using generic repository( i just pass candidate in generic repo and all three list wrt id would return to me) or what is the long query to fill above lists with appropriate data. what is the most suitable way to fill canditae model and pass it to view in terms of best practices

Tuhin Paul · Answer

Instead of using reflection to access the property named "CanId", let's assume that all entities have a property named "CandidateId". This simplifies the code and makes it more maintainable. public interface IRepository { List GetAll(); List GetByCandidateId(int candidateId); // Other generic repository methods can be added as needed } public class Repository : IRepository where T : class { private readonly YourDbContext db; public Repository(YourDbContext dbContext) { db = dbContext; } public List GetAll() { return db.Set ().ToList(); } public List GetByCandidateId(int candidateId) { // Assuming that all entities have a property named "CandidateId" return db.Set ().Where(entity => (int)entity.GetType().GetProperty("CandidateId").GetValue(entity) == candidateId).ToList(); } // Implement other generic repository methods as needed } // Usage in your service or controller public class YourService { private readonly IRepository alertRepository; private readonly IRepository savedJobRepository; private readonly IRepository applicationRepository; public YourService(IRepository alertRepo, IRepository savedJobRepo, IRepository appRepo) { alertRepository = alertRepo; savedJobRepository = savedJobRepo; applicationRepository = appRepo; } public Candidate GetCandidateData(int candidateId) { var candidate = new Candidate { CanId = candidateId }; try { candidate.Alerts = alertRepository.GetByCandidateId(candidateId); candidate.Bookmarks = savedJobRepository.GetByCandidateId(candidateId); candidate.Applications = applicationRepository.GetByCandidateId(candidateId); } catch (Exception ex) { // Handle exceptions gracefully // Log the error // Return null or throw custom exception, as appropriate Console.WriteLine($"Error retrieving candidate data: {ex.Message}"); return null; } return candidate; } }

Jithu Thomas · Answer

Yes, you can achieve this using a generic repository pattern. public interface IRepository { List GetAll(); List GetByCandidateId(int candidateId); // Other generic repository methods can be added as needed } public class Repository : IRepository where T : class { private readonly YourDbContext db; public Repository(YourDbContext dbContext) { db = dbContext; } public List GetAll() { return db.Set ().ToList(); } public List GetByCandidateId(int candidateId) { // Assuming that CanId is a common field in your entities return db.Set ().Where(entity => (int)entity.GetType().GetProperty("CanId").GetValue(entity) == candidateId).ToList(); } // Implement other generic repository methods as needed } // Usage in your service or controller public class YourService { private readonly IRepository alertRepository; private readonly IRepository savedJobRepository; private readonly IRepository applicationRepository; public YourService(IRepository alertRepo, IRepository savedJobRepo, IRepository appRepo) { alertRepository = alertRepo; savedJobRepository = savedJobRepo; applicationRepository = appRepo; } public Candidate GetCandidateData(int candidateId) { var candidate = new Candidate { CanId = candidateId }; candidate.Alerts = alertRepository.GetByCandidateId(candidateId); candidate.Bookmarks = savedJobRepository.GetByCandidateId(candidateId); candidate.Applications = applicationRepository.GetByCandidateId(candidateId); return candidate; } } Make sure to adjust the code based on your actual entity types and context. This is a generic example to give you an idea of how to structure your repository pattern. The idea is to create a generic repository interface and class to handle common CRUD operations, and then inject those repositories into your service or controller. In terms of best practices, it's a good idea to follow the SOLID principles, separate concerns, and keep your code modular and testable. Using a repository pattern can help with data access abstraction and testing.