how to count same names in textFile

Question

I wanna create text file containing one name on each line. Compute the number of times any name occurs. Output one line for each name in file and on each line print the number of occurrences followed by name. and i would like to diplay the answer in messageBox this is what i have done so far. private void button1_Click( object sender, EventArgs e) { var nameCount = new Dictionary string , int >(); foreach ( String s in File .ReadAllLines(openFileDialog1.FileName)) { if (nameCount.ContainsKey(s)) { nameCount[s] = nameCount[s] + 1; } else { nameCount.Add(s, 1); } } var output = new StringBuilder (); foreach ( var pair in nameCount) { MessageBox .Show( String .Format( "{0} {1}
" , pair.Key, pair.Value)); } } private void button1_Click( object sender, EventArgs e) { var nameCount = new Dictionary string , int >(); foreach ( String s in File .ReadAllLines(openFileDialog1.FileName)) { if (nameCount.ContainsKey(s)) { nameCount[s] = nameCount[s] + 1; } else { nameCount.Add(s, 1); } } var output = new StringBuilder (); foreach ( var pair in nameCount) { MessageBox .Show( String .Format( "{0} {1}
" , pair.Key, pair.Value)); } }

Hemant Srivastava · Answer

Here is the solution: private void button1_Click(object sender, EventArgs e) { String sFilePath = "NameFile.txt"; String sLine; Dictionary oNameBag = new Dictionary (); StreamReader strmRdr = new StreamReader(sFilePath); while ((sLine = strmRdr.ReadLine()) != null) { sLine = sLine.Trim(); if (!oNameBag.ContainsKey(sLine)) { oNameBag.Add(sLine, 1); } else { oNameBag[sLine] += 1; } } String sOutput = String.Empty; foreach (KeyValuePair item in oNameBag) { sOutput = sOutput + item.Key + "	" + item.Value + "
"; } MessageBox.Show(sOutput); }

Vulpes · Answer

Your code looks fine to me though, if you'd like all the output to be in a single MessageBox, rather than one per name, then I'd change your output code to this: var output = new StringBuilder(); foreach (var pair in nameCount) { output.Append(String.Format("{0} {1}
", pair.Key, pair.Value)); } MessageBox.Show(output.ToString());