Error in SqlCommand

Question

Hello Guys, Please i have error on the underlined "cmd = new SqlCommand" here is the error message; Sql command.SqlCommand() (+ 3 overload) initialize a new instance of the SlqCommand class. ‘SqlCommand’ does not contain a constructor that takes 8 arguments what constructor can i use to clear the error? Thank you. private void btnSave_Click( object sender, EventArgs e) { // delete old bills details from Row data try { con.Open(); cmd = new SqlCommand( "Delete from Tbl_RowData where JobNo = '" + txtJobNo.Text + "'" , con); cmd.ExecuteNonQuery(); con.Close(); } catch (Exception ex) { MessageBox.Show(ex.Message); } // now save updated Bill data try { for ( int i = 0; i { SqlCommand cmd1 = new SqlCommand( "Insert into Tbl_RowData(SINO,Customer,DescriptionPrice,Quantity,Value,JobNo,Date)values('" + dataGridView1.Rows[i].Cells[0].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[1].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[2].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[3].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[4].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[5].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[6].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[7].Value.ToString() + "')" , con); con.Open(); cmd1.ExecuteNonQuery(); con.Close(); } } catch (Exception ex) { MessageBox.Show(ex.Message); } // now update bill amount, discount and final amount try { con.Open(); cmd = new SqlCommand( "Update Tbl_HeaderData set Date= '" + dateTimePicker1.Value.ToString( "dd/MM/yyyy" )+ "', GoodValue= '" ,txtTotalGoodValue.Text + "', Vat = '" , txtVat.Text+ "', StampDuty='" , txtStampDuty.Text+ "',DeliveryCharges='" , txtDeliveryCharges.Text+ "', OtherCharges='" ,txtOtherCharges.Text+ "', Total= '" , txtTotal.Text+ "'" , con); cmd.ExecuteNonQuery(); con.Close(); MessageBox.Show( "Bill Updated" ); } catch (Exception ex) { MessageBox.Show(ex.Message); } } } }

Shweta Lodha · Answer

Hello Chidiebere Mgbemena, Rather than concatening so much params liek this, please prefer to go with parameterised query as shown below: SqlCommand cmd = new SqlCommand(query, con); //Pass values to Parameters cmd.Parameters.AddWithValue( "@Date" , dateTimePicker1.Value.ToString( "dd/MM/yyyy" )); cmd.Parameters.AddWithValue( "@GoodValue" ,txtTotalGoodValue.Text); More details are here: https://www.completecsharptutorial.com/ado-net/insert-records-using-simple-and-parameterized-query-c-sql.php

Matrick Maths · Answer

"Insert into Tbl_RowData (SINO, Customer, DescriptionPrice, Quantity, Value, JobNo, Date ) //total 7 fields values ( '" + dataGridView1.Rows[i].Cells[0].Value.ToString() + "', //1 '" + dataGridView1.Rows[i].Cells[1].Value.ToString() + "', //2 '" + dataGridView1.Rows[i].Cells[2].Value.ToString() + "', //3 '" + dataGridView1.Rows[i].Cells[3].Value.ToString() + "', //4 '" + dataGridView1.Rows[i].Cells[4].Value.ToString() + "', //5 '" + dataGridView1.Rows[i].Cells[5].Value.ToString() + "', //6 '" + dataGridView1.Rows[i].Cells[6].Value.ToString() + "', //7 '" + dataGridView1.Rows[i].Cells[7].Value.ToString() + "' //8 )" Actually you are passing 8 values instead of 7 (hoping you don't have any identity column )

Chidiebere Mgbemena · Answer

When i tried to save my update, i got this error message "ExecuteNonQuery: Command text property has not been initialized" see below code and screen shot. are my codes not alright? private void btnSave_Click( object sender, EventArgs e) { // delete old bills details from Row data try { con.Open(); cmd = new SqlCommand( "Delete from Tbl_RowData where JobNo = '" + txtJobNo.Text + "'" , con); cmd.ExecuteNonQuery(); con.Close(); } catch (Exception ex) { MessageBox.Show(ex.Message); } // now save updated Bill data try { for ( int i = 0; i { SqlCommand cmd1 = new SqlCommand( "Insert into Tbl_RowData(SINO,Customer,Description,Price,Quantity,Value,JobNo,Date)values('" + dataGridView1.Rows[i].Cells[0].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[1].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[2].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[3].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[4].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[5].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[6].Value.ToString() + "','" + dataGridView1.Rows[i].Cells[7].Value.ToString() + "')" , con); con.Open(); cmd1.Connection = con; cmd1.CommandType = CommandType.Text; cmd1.ExecuteNonQuery(); con.Close(); MessageBox.Show( "Bill Updated" ); } } catch (Exception ex) { MessageBox.Show(ex.Message); } // now update bill amount, discount and final amount try { con.Open(); SqlCommand cmd = new SqlCommand(query, con); //Pass values to Parameters cmd.Parameters.AddWithValue( "@Date" , dateTimePicker1.Value.ToString( "dd/MM/yyyy" )); cmd.Parameters.AddWithValue( "@GoodValue" , txtTotalGoodValue.Text); cmd.Parameters.AddWithValue( "@Vat" , txtVat.Text); cmd.Parameters.AddWithValue( "@StampDuty" , txtStampDuty.Text); cmd.Parameters.AddWithValue( "@DeliveryCharges" , txtDeliveryCharges.Text); cmd.Parameters.AddWithValue( "@OtherCharges" , txtOtherCharges.Text); cmd.Parameters.AddWithValue( "@Tota" , txtTotal.Text); cmd.Connection = con; cmd.CommandType = CommandType.Text; cmd.ExecuteNonQuery(); con.Close(); MessageBox.Show( "Bill Updated" ); } catch (Exception ex) { MessageBox.Show(ex.Message); } } } }

Jignesh Kumar · Answer

Hi, Please refer below link, https://www.c-sharpcorner.com/forums/saving-gridview-data-to-database https://stackoverflow.com/questions/10556556/insert-all-data-of-a-datagridview-to-database-at-once