Counter count to 10, end then 10,10,10,10,...at 1 to 9 is ev

Question

Counter count to 10, end then 10,10,10,10,...at 1 to 9 is everithing is ok...

What is wrong

SqlDataReader rdr;
SqlCommand cmd = new SqlCommand();
cmd.CommandText = "select max(brojprijavnice2) from dbo.prijava_radnika ";
cmd.Connection = con;
con.Open();
rdr = cmd.ExecuteReader();
int max = 0;
while (rdr.Read())
{
max = Convert.ToInt32(rdr[0].ToString());
Console.WriteLine(max);
}
con.Close();
String updateStaff = "UPDATE [dbo].[prijava_radnika] SET [vrijemeodjave] = @vrijemeodjave, brojprijavnice2 = '" + (max+1) + "', [status] = 'odjavljen' WHERE radnik = '" + readerresultTextbox.Text + "' and [status] = 'prijavljen'";

Nitin Sontakke · Answer

Exactly, change it to int and you are done. Rest all is fine.

Nitin Sontakke · Answer

What is the data type and length of the column you are trying to update? You can paste the table structure here. Also, are you sending the value of @vrijemeodjave variable as a parameter? If yes, why not concatenate just like all other statement?

Goran Bibic · Answer

Nitin Sontakke Problem with this code is is vrijeme odajave row emtpy, program not start... And counter same not work?

Goran Bibic · Answer

I try this but same... 1,2,3,4,5,6,7,8,9,10,10,10,10,10... String updateStaff = " declare @maxNo integer = 0 select @maxNo = isnull(max(brojprijavnice2), 1) from[dbo].[prijava_radnika] UPDATE[dbo].[prijava_radnika] SET" + " [vrijemeodjave] = @vrijemeodjave,[brojprijavnice2] = (@maxNo+1),[status] = 'odjavljen' WHERE radnik = '" + readerresultTextbox.Text + "'and[status] = 'prijavljen'" ;

Nitin Sontakke · Answer

First, you should actually try to do all of this in a stored procedure only. If you see your code, you are getting data from back-end to C# and then again passing it back to back-end by just adding one to it. Why not do everything there itself? String updateStaff = " declare @maxNo integer = 0 select @maxNo = isnull(max(brojprijavnice2), 1) from [dbo].[prijava_radnika] UPDATE [dbo].[prijava_radnika] SET [vrijemeodjave] = @vrijemeodjave ,[brojprijavnice2] = @maxNo ,[status] = 'odjavljen' WHERE radnik = '" + readerresultTextbox.Text + "' and [status] = 'prijavljen' ";

Goran Bibic · Answer

Same...1,2,3,4,5,6,7,8,9,10,10,10,10,10,10,10,10,,,,,no have 11,12,13...etc...when I manuali repair in sql 11,12,13...next is 10,10,10,10...max vaulue in counter is 10?

Goran Bibic · Answer

[IdPrijava] int ,[vrijemeprijave] ,[vrijemeodjave] datetime ,[status]varchar(255) ,[vrijemedolaska]datetime ,[vrijemeodlaska]datetime ,[radnik]varchar(255) ,[organizacionajedinica]varchar(255) ,[radni_sati] int ,[prekovremeni] int ,[brojprijavnice2] varchar(255) //here is error data type is not int i think ,[radni_sati2]varchar(255) ,[idfakture] int FROM [bss_prijava_radnika].[dbo].[prijava_radnika]