c# working set memory keeps increase with every call to a method

Question

I programmed a c# program that has a timer. this timer will call a method. but every time when the method is called, the working memory of that program keeps increase does anyone know what is wrong with my program

theLizard · Answer

why are you opening and closing database every 10 seconds for? when database is open what are you doing with it? Doing this may eventually exceed the connection pool and you are not giving the database time to recover connections within the timeout period. You obviously have memory leak but without seeing code it would be dificult to determine where the problem is.

goh · Answer

I deploys the application under active configuration but the result is the same I closes the datareader first and the database connection but the result is the same

theLizard · Answer

what have you opened? do you have you opened a connection and a data reader? if you have you must 1st connection.close() the connection then connection.dispose(0 it same with data reader or any other open item reader.close() reader.dispose, command.close command.dispose(). you must also first check that these are not null otherwise you will get errors.

naura pax · Answer

hi goh, are you building your application in debug mode? if yes then you should try to build it in release mode and then deploy, that might just make a difference.

goh · Answer

an other weird thing is whenever I catch an exception in try and catch, working set will increase and will not decrease. I tried the dispose method and it does not solve the error

naura pax · Answer

you should call the Dispose method of connection object in finally method.

goh · Answer

is it because I cant programming a timer in window service?

goh · Answer

private void TimerEvent() { try load database }finally{ close database } } the most funny thing is even I close the database. the c# wont recover the memory back but when I load a new data, working set will increase this program is c# window service.

theLizard · Answer

what are you doing in the function?

goh · Answer

i set the timer autoreset to true

goh · Answer

no i did not unsubscribe it. because My program will call the method in every 10 seconds interval do i have to unsubscribe it and resubscribe it?

naura pax · Answer

hi goh, Have you set the tick event of timer at runtime if yes then exactly at which event? if you have subscribed to event handler using code then you can unsubscribe it at that time: timer1.tick-=new System.EventHandler(this.timer1_Tick); timer1.tick+=new System.EventHandler(this.timer1_Tick); hope i'm close.